Skip to content

Fix flaky npm github release #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

Fix flaky npm github release #1225

merged 3 commits into from
Feb 12, 2025

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Feb 12, 2025

Fix flaky npm github release

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 4ff005a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (bf86857) to head (4ff005a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   83.52%   91.09%   +7.56%     
==========================================
  Files         217      162      -55     
  Lines        5810     4346    -1464     
  Branches     1324     1042     -282     
==========================================
- Hits         4853     3959     -894     
+ Misses        957      387     -570
Flag Coverage Δ
browser 92.22% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silesky silesky enabled auto-merge (squash) February 12, 2025 20:17
@silesky silesky disabled auto-merge February 12, 2025 20:19
@silesky silesky merged commit 794eb4c into master Feb 12, 2025
7 of 8 checks passed
@silesky silesky deleted the fix-flaky-npm-publish branch February 12, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alanjcharles alanjcharles alanjcharles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silesky @alanjcharles